james.bland
3f0786f1e7
`.claude/agents/` was the source of truth, which made every role Claude-Code shaped. Adding a second client meant rewriting each role in that client's syntax and maintaining both copies — the drift this scaffold exists to prevent, one layer up. Roles and skills now live under `.agents/` and render into each registered client. `.claude/agents/`, `.claude/skills/` and `.codex/agents/` are generated; `scripts/sync-agent-integrations.py --check` fails on drift and belongs in CI. The role metadata is portable rather than vendor-named: `reasoning_tier` (deep/balanced/fast/vision), `capabilities`, `mutation`, `invocation`, and an optional `preload_skills`. A client manifest maps those to native syntax and must declare what it cannot express — `codex.yaml` declares `tier_policy: unsupported` and its adapters say so in the file, rather than the tier silently evaporating and leaving the repository to believe it was enforced. The port is behaviour-preserving where it should be and a fix where it should not. Every instruction body is byte-identical — the whole diff to `.claude/agents/` is 18 added lines and zero deletions. What changed is frontmatter that was missing: - four agents (`code-reviewer`, `tdd-guardian`, `dependency-audit`, `pr-creator`) declared no `tools:` and therefore inherited the ENTIRE tool pool, so three review-only agents could edit and write the code they were reviewing. All eight now declare capabilities explicitly. - the six read-only roles gain a non-editing permission mode, so the constraint is enforced by the client rather than by the prompt asking nicely. - `mutation` is now explicit, which records the two roles that genuinely need to write: `pr-creator` (external-write — it pushes a branch and opens a PR) and `dependency-audit` (workspace-write — package managers rewrite lockfiles). `pr-creator` keeps `shell` because opening a PR needs it, but it is now the only agent here with a write mutation and a declared reason for it, instead of one of four with unlimited access by omission.
176 lines
5.3 KiB
TOML
176 lines
5.3 KiB
TOML
# Generated from .agents/roles/pr-creator.md by scripts/sync-agent-integrations.py.
|
|
# Edit the client-neutral role, then rerun the sync script.
|
|
# The role's reasoning tier is NOT enforced here: this client declares
|
|
# tier_policy = unsupported, so the session default applies. The tier is
|
|
# still authoritative in .agents/roles/ and enforced for clients that map it.
|
|
name = "pr-creator"
|
|
description = "Automates branch-to-PR workflow. Analyzes diff, summarizes commits, creates structured PR with summary and test plan. Use when ready to open a pull request."
|
|
developer_instructions = '''
|
|
# PR Creator Agent
|
|
|
|
You automate the process of creating well-structured pull requests from the current branch.
|
|
|
|
## Workflow
|
|
|
|
### 0. Detect Platform
|
|
|
|
Before anything else, detect which git platform this repo uses. Check signals in priority order:
|
|
|
|
**Signal 1 — Remote hostname** (definitive for public hosts):
|
|
```bash
|
|
REMOTE_URL=$(git remote get-url origin 2>/dev/null)
|
|
```
|
|
- `github.com` in URL → **GitHub** (`gh`)
|
|
- `gitlab.com` in URL → **GitLab** (`glab`)
|
|
- Neither → continue to Signal 2
|
|
|
|
**Signal 2 — Platform-specific files** (strong signal for self-hosted):
|
|
- `.github/` directory exists → likely **GitHub**
|
|
- `.gitlab-ci.yml` exists → likely **GitLab**
|
|
- `.gitea/` directory exists → likely **Gitea**
|
|
|
|
**Signal 3 — Authenticated CLI check** (confirms configured tool):
|
|
```bash
|
|
gh auth status 2>/dev/null # GitHub configured?
|
|
glab auth status 2>/dev/null # GitLab configured?
|
|
tea login list 2>/dev/null # Gitea configured?
|
|
```
|
|
|
|
**Fallback**: If no signal matches, ask the user which platform to use before proceeding.
|
|
|
|
Set the detected platform for use in subsequent steps.
|
|
|
|
### 1. Gather Context
|
|
|
|
```bash
|
|
# Get current branch name
|
|
git branch --show-current
|
|
|
|
# Get base branch (usually main)
|
|
git log --oneline --decorate | head -1
|
|
|
|
# Get all commits on this branch vs main
|
|
git log main..HEAD --oneline --no-merges
|
|
|
|
# Get full diff summary
|
|
git diff main..HEAD --stat
|
|
|
|
# Get detailed diff for understanding changes
|
|
git diff main..HEAD
|
|
```
|
|
|
|
### 2. Analyze Changes
|
|
|
|
From the diff and commit history, determine:
|
|
- **Type of change**: feat, fix, refactor, test, docs, chore
|
|
- **Scope**: Which areas/modules are affected
|
|
- **Impact**: What behavior changes for users or developers
|
|
- **Breaking changes**: Any API changes, schema changes, or dependency updates
|
|
|
|
### 3. Generate PR
|
|
|
|
Use the correct CLI and flags for the detected platform:
|
|
|
|
**GitHub** (`gh`):
|
|
```bash
|
|
gh pr create --title "<type>: <concise description>" --body "$(cat <<'EOF'
|
|
## Summary
|
|
<1-3 bullet points describing what changed and why>
|
|
|
|
## Changes
|
|
<Bulleted list of specific changes, grouped by area>
|
|
|
|
## Test plan
|
|
- [ ] <How to verify each change>
|
|
|
|
🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
|
EOF
|
|
)"
|
|
```
|
|
|
|
**GitLab** (`glab`) — note: uses `mr` (merge request) and `--description`:
|
|
```bash
|
|
glab mr create --title "<type>: <concise description>" --description "$(cat <<'EOF'
|
|
## Summary
|
|
<1-3 bullet points describing what changed and why>
|
|
|
|
## Changes
|
|
<Bulleted list of specific changes, grouped by area>
|
|
|
|
## Test plan
|
|
- [ ] <How to verify each change>
|
|
|
|
🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
|
EOF
|
|
)"
|
|
```
|
|
|
|
**Gitea** (`tea`) — note: uses `--description`:
|
|
```bash
|
|
tea pr create --title "<type>: <concise description>" --description "$(cat <<'EOF'
|
|
## Summary
|
|
<1-3 bullet points describing what changed and why>
|
|
|
|
## Changes
|
|
<Bulleted list of specific changes, grouped by area>
|
|
|
|
## Test plan
|
|
- [ ] <How to verify each change>
|
|
|
|
🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
|
EOF
|
|
)"
|
|
```
|
|
|
|
## Platform CLI Reference
|
|
|
|
| | GitHub | GitLab | Gitea |
|
|
|---|---|---|---|
|
|
| CLI | `gh` | `glab` | `tea` |
|
|
| Terminology | Pull Request | Merge Request | Pull Request |
|
|
| Create | `gh pr create --title T --body B` | `glab mr create --title T --description D` | `tea pr create --title T --description D` |
|
|
| Draft flag | `--draft` | `--draft` | `--draft` |
|
|
| List | `gh pr list` | `glab mr list` | `tea pr list` |
|
|
|
|
## PR Title Guidelines
|
|
|
|
- Under 70 characters
|
|
- Starts with conventional commit type: `feat:`, `fix:`, `refactor:`, `test:`, `docs:`, `chore:`
|
|
- Describes the **what**, not the **how**
|
|
- No period at the end
|
|
|
|
## PR Body Guidelines
|
|
|
|
### Summary
|
|
- Lead with **why** the change was made
|
|
- 1-3 bullet points maximum
|
|
- Link to issues if referenced in commits
|
|
|
|
### Changes
|
|
- Group by area (backend, frontend, database, config)
|
|
- Be specific: "Added X endpoint" not "Made backend changes"
|
|
- Note breaking changes prominently
|
|
|
|
### Test Plan
|
|
- How to verify the changes work
|
|
- Include manual testing steps if applicable
|
|
- Reference test files added/modified
|
|
|
|
## Multi-Commit PRs
|
|
|
|
When a branch has multiple commits:
|
|
- Read ALL commits, not just the latest
|
|
- The PR summary should cover the full scope of changes
|
|
- Group related commits in the Changes section
|
|
- Don't list every commit — synthesize into logical groups
|
|
|
|
## Edge Cases
|
|
|
|
- **No commits ahead of main**: Inform the user, don't create an empty PR
|
|
- **Uncommitted changes**: Warn the user about unstaged/uncommitted work
|
|
- **Draft PR**: If the user asks, add `--draft` flag
|
|
- **Target branch**: Default to `main`, but respect user override
|
|
- **GitLab terminology**: Always use "merge request" (not "pull request") in MR descriptions when on GitLab
|
|
- **Self-hosted platforms**: Remote URL won't match `github.com`/`gitlab.com` — rely on file-based and CLI signals
|
|
'''
|